Re: [PATCH] die_with_status: use "printf '%s\n'", not "echo"

Matthieu Moy writes: > Thomas Rast writes: > >>> + grep -v " " error >> >> Umm, doesn't that only test that _some_ line in the error does not >> contain a tab? > > Indeed. It does work as the error message is just a one-liner, but let's > be robust anyway. Err, right. I actually applie

Re: [PATCH] die_with_status: use "printf '%s\n'", not "echo"

Thomas Rast writes: >> +grep -v " " error > > Umm, doesn't that only test that _some_ line in the error does not > contain a tab? Indeed. It does work as the error message is just a one-liner, but let's be robust anyway. > Whereas you need to test that _no_ line contains emp, or some

Re: [PATCH] die_with_status: use "printf '%s\n'", not "echo"

Matthieu Moy writes: > At least GNU echo interprets backslashes in its arguments. > > This triggered at least one bug: the error message of "rebase -i" was > turning \t in commit messages into actual tabulations. There may be > others. > > Using "printf '%s\n'" instead avoids this bad behavior, a

[PATCH] die_with_status: use "printf '%s\n'", not "echo"

At least GNU echo interprets backslashes in its arguments. This triggered at least one bug: the error message of "rebase -i" was turning \t in commit messages into actual tabulations. There may be others. Using "printf '%s\n'" instead avoids this bad behavior, and is the form used by the "say" fu