Re: [PATCH] diff: allow --recurse-submodules as an synonym for --submodule

2018-09-07 Thread Junio C Hamano
Jonathan Nieder writes: > When I think about it this way, I suspect that (B) will provide a > better experience than (A), so this diff change doesn't seem like a > step in the wrong direction. OK, that's fair.

Re: [PATCH] diff: allow --recurse-submodules as an synonym for --submodule

2018-09-07 Thread Jonathan Nieder
Junio C Hamano wrote: > Jonathan Nieder writes: >> It seems like various commands are gaining --recurse-submodules options >> taking different kinds of arguments: >> >> - clone takes --recurse-submodules= >> - fetch takes --recurse-submodules= >> - after this patch, diff takes

Re: [PATCH] diff: allow --recurse-submodules as an synonym for --submodule

2018-09-06 Thread Stefan Beller
On Thu, Sep 6, 2018 at 2:12 PM Junio C Hamano wrote: > > Jonathan Nieder writes: > > > It seems like various commands are gaining --recurse-submodules options > > taking different kinds of arguments: > > > > - clone takes --recurse-submodules= > > - fetch takes --recurse-submodules= > > - after

Re: [PATCH] diff: allow --recurse-submodules as an synonym for --submodule

2018-09-06 Thread Junio C Hamano
Jonathan Nieder writes: > It seems like various commands are gaining --recurse-submodules options > taking different kinds of arguments: > > - clone takes --recurse-submodules= > - fetch takes --recurse-submodules= > - after this patch, diff takes --recurse-submodules= > > Is there a unifying

Re: [PATCH] diff: allow --recurse-submodules as an synonym for --submodule

2018-09-06 Thread Stefan Beller
On Wed, Sep 5, 2018 at 4:13 PM Jonathan Nieder wrote: > > Stefan Beller wrote: > > > Many commands have flags to recurse into submodules, which is named > > --recurse-submodules. The diff family also has a submodule recursion flag, > > but that is named differently. Add a synonym

[PATCH] diff: allow --recurse-submodules as an synonym for --submodule

2018-09-06 Thread Stefan Beller
Many commands have flags to recurse into submodules, which is named --recurse-submodules. The diff family also has a submodule recursion flag, but that is named differently. Add a synonym --recurse-submodules, which means the same as the --submodule flag, such that across all git commands

Re: [PATCH] diff: allow --recurse-submodules as an synonym for --submodule

2018-09-06 Thread Martin Ă…gren
On Thu, 6 Sep 2018 at 00:59, Stefan Beller wrote: > > --submodule[=]:: Maybe drop `--submodule` here ... > +--recurse-submodules[=]:: > Specify how differences in submodules are shown. When specifying > `--submodule=short` the 'short' format is used. This format just ... and

Re: [PATCH] diff: allow --recurse-submodules as an synonym for --submodule

2018-09-05 Thread Jonathan Nieder
Stefan Beller wrote: > Many commands have flags to recurse into submodules, which is named > --recurse-submodules. The diff family also has a submodule recursion flag, > but that is named differently. Add a synonym --recurse-submodules, which > means the same as the --submodule flag, such that

[PATCH] diff: allow --recurse-submodules as an synonym for --submodule

2018-09-05 Thread Stefan Beller
Many commands have flags to recurse into submodules, which is named --recurse-submodules. The diff family also has a submodule recursion flag, but that is named differently. Add a synonym --recurse-submodules, which means the same as the --submodule flag, such that across all git commands