Re: [PATCH] diff: differentiate error handling in parse_color_moved_ws

2018-11-05 Thread Stefan Beller
On Sun, Nov 4, 2018 at 10:12 PM Junio C Hamano wrote: > > Junio C Hamano writes: > > > Stefan Beller writes: > > > >> > >> -static int parse_color_moved_ws(const char *arg) > >> +static unsigned parse_color_moved_ws(const char *arg) > >> { > >> int ret = 0; > >> struct string_list l =

Re: [PATCH] diff: differentiate error handling in parse_color_moved_ws

2018-11-04 Thread Junio C Hamano
Junio C Hamano writes: > Stefan Beller writes: > >> >> -static int parse_color_moved_ws(const char *arg) >> +static unsigned parse_color_moved_ws(const char *arg) >> { >> int ret = 0; >> struct string_list l = STRING_LIST_INIT_DUP; >> @@ -312,15 +312,19 @@ static int parse_color_mov

Re: [PATCH] diff: differentiate error handling in parse_color_moved_ws

2018-11-02 Thread Junio C Hamano
Stefan Beller writes: > > -static int parse_color_moved_ws(const char *arg) > +static unsigned parse_color_moved_ws(const char *arg) > { > int ret = 0; > struct string_list l = STRING_LIST_INIT_DUP; > @@ -312,15 +312,19 @@ static int parse_color_moved_ws(const char *arg) >

[PATCH] diff: differentiate error handling in parse_color_moved_ws

2018-11-02 Thread Stefan Beller
As we check command line options more strictly and allow configuration variables to be parsed more leniently, we need take different actions based on whether an unknown value is given on the command line or in the config. Move the die() call out of parse_color_moved_ws into the parsing of command