Re: [PATCH] dir.c: ignore paths containing .git when invalidating untracked cache

2018-02-06 Thread Duy Nguyen
On Tue, Feb 6, 2018 at 12:44 AM, Ben Peart wrote: > > > On 2/4/2018 4:38 AM, Nguyễn Thái Ngọc Duy wrote: >> >> read_directory() code ignores all paths named ".git" even if it's not >> a valid git repository. See treat_path() for details. Since ".git" is >> basically invisible

Re: [PATCH] dir.c: ignore paths containing .git when invalidating untracked cache

2018-02-05 Thread Ben Peart
On 2/4/2018 4:38 AM, Nguyễn Thái Ngọc Duy wrote: read_directory() code ignores all paths named ".git" even if it's not a valid git repository. See treat_path() for details. Since ".git" is basically invisible to read_directory(), when we are asked to invalidate a path that contains ".git", we

[PATCH] dir.c: ignore paths containing .git when invalidating untracked cache

2018-02-04 Thread Nguyễn Thái Ngọc Duy
read_directory() code ignores all paths named ".git" even if it's not a valid git repository. See treat_path() for details. Since ".git" is basically invisible to read_directory(), when we are asked to invalidate a path that contains ".git", we can safely ignore it because the slow path would not