Re: [PATCH] fetch-pack: approximate no_dependents with filter

2018-09-29 Thread Junio C Hamano
Jonathan Tan writes: > This was prompted by a user at $DAY_JOB who had a partial clone > excluding trees, and had a workflow that only required tree objects (and > not blobs). > > This will hopefully make partial clones excluding trees (with the > "tree:0" filter) a bit better, in that if an

Re: [PATCH] fetch-pack: approximate no_dependents with filter

2018-09-27 Thread Jonathan Tan
> It is very clear how you are churning the code, but it is utterly > unclear from the description what you perceived as a problem and why > this change is a good (if not the best) solution for that problem, > at least to me. Firstly, thanks for your comments and questions - it's sometimes hard

Re: [PATCH] fetch-pack: approximate no_dependents with filter

2018-09-25 Thread Junio C Hamano
Jonathan Tan writes: > Whenever a lazy fetch is performed for a tree object, any trees and > blobs it directly or indirectly references will be fetched as well. > There is a "no_dependents" argument in struct fetch_pack_args that > indicates that objects that the wanted object references need

[PATCH] fetch-pack: approximate no_dependents with filter

2018-09-24 Thread Jonathan Tan
Whenever a lazy fetch is performed for a tree object, any trees and blobs it directly or indirectly references will be fetched as well. There is a "no_dependents" argument in struct fetch_pack_args that indicates that objects that the wanted object references need not be sent, but it currently has