Re: [PATCH] fetch-pack: grow stateless RPC windows exponentially

2016-07-18 Thread Junio C Hamano
Jonathan Tan writes: > and it would look like that patch. (I would probably redefine > LARGE_FLUSH to be 10 times its current value instead of multiplying it > by 10, since it is not used anywhere else.) Sounds good. Care to do the final version of the patch to be applied? Thanks. -- To unsubs

Re: [PATCH] fetch-pack: grow stateless RPC windows exponentially

2016-07-18 Thread Jonathan Tan
On Mon, Jul 18, 2016 at 1:00 PM, Junio C Hamano wrote: > Jonathan Nieder writes: > >> You have full control of the growth function. So how about aggressive >> growth until 1024*10? >> >> That is: >> >> Current git: >> n < 1024: aggressive exponential >> 16, 32, 64, 128, 256, 512, 1024 >>

Re: [PATCH] fetch-pack: grow stateless RPC windows exponentially

2016-07-18 Thread Junio C Hamano
Jonathan Nieder writes: > You have full control of the growth function. So how about aggressive > growth until 1024*10? > > That is: > > Current git: > n < 1024: aggressive exponential > 16, 32, 64, 128, 256, 512, 1024 > 1024 <= n: linear > 2048, 3072, 4096, 5120, ... > > Initial

Re: [PATCH] fetch-pack: grow stateless RPC windows exponentially

2016-07-18 Thread Jonathan Nieder
Jonathan Tan wrote: > On Mon, Jul 18, 2016 at 12:10 PM, Junio C Hamano wrote: >> I'd understand if it were more like "aggressive exponential -> >> conservative exponential" without linear phase when stateless_rpc is >> in use, though. I just do not quite understand the justification >> behind th

Re: [PATCH] fetch-pack: grow stateless RPC windows exponentially

2016-07-18 Thread Jonathan Tan
On Mon, Jul 18, 2016 at 12:10 PM, Junio C Hamano wrote: > I'd understand if it were more like "aggressive exponential -> > conservative exponential" without linear phase when stateless_rpc is > in use, though. I just do not quite understand the justification > behind the order of three phases int

Re: [PATCH] fetch-pack: grow stateless RPC windows exponentially

2016-07-18 Thread Junio C Hamano
Jonathan Nieder writes: > Yay, thanks for this. > > When this condition triggers (count >= 10240), we have already > experienced 10 rounds of negotiation. Negotiation ought to have > finished by then. So this is a pretty conservative change to try to > salvage an already bad situation. > > The

Re: [PATCH] fetch-pack: grow stateless RPC windows exponentially

2016-07-18 Thread Jonathan Nieder
Hi, Jonathan Tan wrote: > When updating large repositories, the LARGE_FLUSH limit (that is, the > limit at which the window growth strategy switches from exponential to > linear) is reached quite quickly. Use a conservative exponential growth > strategy when that limit is reached instead. > > Thi

[PATCH] fetch-pack: grow stateless RPC windows exponentially

2016-07-18 Thread Jonathan Tan
When updating large repositories, the LARGE_FLUSH limit (that is, the limit at which the window growth strategy switches from exponential to linear) is reached quite quickly. Use a conservative exponential growth strategy when that limit is reached instead. This optimization is only applied during