Re: [PATCH] fetch-pack: mark die strings for translation

2018-07-23 Thread Brandon Williams
On 07/23, Junio C Hamano wrote: > Junio C Hamano writes: > > > Brandon Williams writes: > > > >> Signed-off-by: Brandon Williams > >> --- > >> fetch-pack.c | 16 > >> 1 file changed, 8 insertions(+), 8 deletions(-) > > > > I do think this is a good idea, but what release does

Re: [PATCH] fetch-pack: mark die strings for translation

2018-07-23 Thread Junio C Hamano
Junio C Hamano writes: > Brandon Williams writes: > >> Signed-off-by: Brandon Williams >> --- >> fetch-pack.c | 16 >> 1 file changed, 8 insertions(+), 8 deletions(-) > > I do think this is a good idea, but what release does this target? > It does not seem to apply to

Re: [PATCH] fetch-pack: mark die strings for translation

2018-07-23 Thread Junio C Hamano
Brandon Williams writes: > Signed-off-by: Brandon Williams > --- > fetch-pack.c | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) I do think this is a good idea, but what release does this target? It does not seem to apply to master@{4.hours.ago}, and I do not think a

Re: [PATCH] fetch-pack: mark die strings for translation

2018-07-23 Thread Jonathan Nieder
Brandon Williams wrote: > Signed-off-by: Brandon Williams > --- > fetch-pack.c | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) Reviewed-by: Jonathan Nieder Thanks.

Re: [PATCH] fetch-pack: mark die strings for translation

2018-07-23 Thread Stefan Beller
On Mon, Jul 23, 2018 at 10:56 AM Brandon Williams wrote: > fetch-pack is listed as a plumbing command, which means its prime consumer is supposedly a machine; But fetch-pack is also used by git-fetch that is invoked by a human, who prefers translations. .. goes reads code... This translates

[PATCH] fetch-pack: mark die strings for translation

2018-07-23 Thread Brandon Williams
Signed-off-by: Brandon Williams --- fetch-pack.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/fetch-pack.c b/fetch-pack.c index 0b4a9f288f..51abee6181 100644 --- a/fetch-pack.c +++ b/fetch-pack.c @@ -1245,13 +1245,13 @@ static int