Re: [PATCH] fetch-pack: optionally save packs to disk

2015-06-11 Thread Junio C Hamano
Augie Fackler writes: > @@ -708,9 +708,8 @@ static int get_pack(struct fetch_pack_args *args, > cmd.argv = argv; > av = argv; > *hdr_arg = 0; > + struct pack_header header; decl-after-stmt here... > if (!args->keep_pack && unpack_limit) { > - struct pack_

Re: [PATCH] fetch-pack: optionally save packs to disk

2015-06-11 Thread Stefan Beller
On Thu, Jun 11, 2015 at 10:44 AM, Augie Fackler wrote: > When developing server software, it's often helpful to save a > potentially-bogus pack for later analysis. This makes that trivial, > instead of painful. This is made a little complicated by the fact that > in some cases (like cloning from s

[PATCH] fetch-pack: optionally save packs to disk

2015-06-11 Thread Augie Fackler
When developing server software, it's often helpful to save a potentially-bogus pack for later analysis. This makes that trivial, instead of painful. This is made a little complicated by the fact that in some cases (like cloning from smart-http, but not from a local repo) the fetch code reads the p