Re: [PATCH] format-patch: escape "From " lines recognized by mailsplit

Junio C Hamano wrote: > Eric Wong writes: > > >> Also, doesn't it break "git rebase" (non-interactive), or anything > >> that internally runs format-patch to individual files and then runs > >> am on each of them, anything that knows that each output file from

Re: [PATCH] format-patch: escape "From " lines recognized by mailsplit

Eric Wong writes: >> Also, doesn't it break "git rebase" (non-interactive), or anything >> that internally runs format-patch to individual files and then runs >> am on each of them, anything that knows that each output file from >> format-patch corresponds to a single change and

Re: [PATCH] format-patch: escape "From " lines recognized by mailsplit

Junio C Hamano wrote: > Junio C Hamano writes: > > Eric Wong writes: > > > >> Users have mistakenly copied "From " lines into commit messages > >> in the past, and will certainly make the same mistakes in the > >> future. Since not everyone

Re: [PATCH] format-patch: escape "From " lines recognized by mailsplit

Junio C Hamano writes: > Eric Wong writes: > >> Users have mistakenly copied "From " lines into commit messages >> in the past, and will certainly make the same mistakes in the >> future. Since not everyone uses mboxrd, yet, we should at least >> prevent

Re: [PATCH] format-patch: escape "From " lines recognized by mailsplit

Junio C Hamano wrote: > As a tool to produce mbox file, quoting like this in format-patch > output may make sense, I would think, but shouldn't send-email undo > this when sending individual patches? Yes, that sounds like a good idea. Thanks. Will followup in a day or two. --

Re: [PATCH] format-patch: escape "From " lines recognized by mailsplit

Eric Wong writes: > Users have mistakenly copied "From " lines into commit messages > in the past, and will certainly make the same mistakes in the > future. Since not everyone uses mboxrd, yet, we should at least > prevent miss-split mails by always escaping "From " lines based

Re: [PATCH] format-patch: escape "From " lines recognized by mailsplit

or you to fetch changes up to 4f769f1799db11f135948bf517f2d8d864fa778f: format-patch: escape "From " lines recognized by mailsplit (2016-07-23 21:38:40 +) Eric Wong (2): mailinfo: extract is_from_line from mai

Re: [PATCH] format-patch: escape "From " lines recognized by mailsplit

Hi Eric, I think that this change: On Fri, 22 Jul 2016, Eric Wong wrote: > diff --git a/builtin/mailsplit.c b/builtin/mailsplit.c > index 3068168..bb8f9c9 100644 > --- a/builtin/mailsplit.c > +++ b/builtin/mailsplit.c > @@ -8,41 +8,11 @@ > #include "builtin.h" > #include "string-list.h" >

[PATCH] format-patch: escape "From " lines recognized by mailsplit

Users have mistakenly copied "From " lines into commit messages in the past, and will certainly make the same mistakes in the future. Since not everyone uses mboxrd, yet, we should at least prevent miss-split mails by always escaping "From " lines based on the check used by mailsplit. mailsplit