Re: [PATCH] gc: remove gc.pid file at end of execution

2013-10-16 Thread Junio C Hamano
Jonathan Nieder writes: > Matthieu Moy wrote: > >> This file isn't really harmful, but isn't useful either, and can create >> minor annoyance for the user: > > Would something like the following make sense, to ensure the gc.pid file is > always removed on normal exit? Has anything further happen

Re: [PATCH] gc: remove gc.pid file at end of execution

2013-09-27 Thread Duy Nguyen
On Sat, Sep 28, 2013 at 7:33 AM, Jonathan Nieder wrote: > Matthieu Moy wrote: > >> This file isn't really harmful, but isn't useful either, and can create >> minor annoyance for the user: > > Would something like the following make sense, to ensure the gc.pid file is > always removed on normal exi

Re: [PATCH] gc: remove gc.pid file at end of execution

2013-09-27 Thread Jonathan Nieder
Matthieu Moy wrote: > This file isn't really harmful, but isn't useful either, and can create > minor annoyance for the user: Would something like the following make sense, to ensure the gc.pid file is always removed on normal exit? Signed-off-by: Jonathan Nieder diff --git c/builtin/gc.c i/bu

[PATCH] gc: remove gc.pid file at end of execution

2013-09-26 Thread Matthieu Moy
This file isn't really harmful, but isn't useful either, and can create minor annoyance for the user: * It's confusing, as the presence of a *.pid file often implies that a process is currently running. A user running "ls .git/" and finding this file may incorrectly guess that a "git gc" is cu