Re: [PATCH] git-p4: changelist template with p4 -G change -o

Hi Lars/Luke, I tried a first test extending t9807-git-p4-submit.sh. I set this p4 trigger: 'p4test command pre-user-change "echo verbose trigger" '. I'm able to reproduce the issue I wanted to fix. However I found yet another issue, in this case when reading the result from p4_read_pipe_lines

Re: [PATCH] git-p4: changelist template with p4 -G change -o

> On 24 Jun 2017, at 13:49, Luke Diamand wrote: > > On 22 June 2017 at 18:32, Junio C Hamano wrote: >> Miguel Torroja writes: >> >>> The option -G of p4 (python marshal output) gives more context about the >>> data being output.

Re: [PATCH] git-p4: changelist template with p4 -G change -o

You are right about the "# add"comment. I couldn't find any extra info in the marshaled output that I can use to add the change action comment after the path. That's one downside of that change. On Sat, Jun 24, 2017 at 1:49 PM, Luke Diamand wrote: > On 22 June 2017 at 18:32,

Re: [PATCH] git-p4: changelist template with p4 -G change -o

On 22 June 2017 at 18:32, Junio C Hamano wrote: > Miguel Torroja writes: > >> The option -G of p4 (python marshal output) gives more context about the >> data being output. That's useful when using the command "change -o" as >> we can distinguish

Re: [PATCH] git-p4: changelist template with p4 -G change -o

Miguel Torroja writes: > The option -G of p4 (python marshal output) gives more context about the > data being output. That's useful when using the command "change -o" as > we can distinguish between warning/error line and real change description. > > Some p4

[PATCH] git-p4: changelist template with p4 -G change -o

The option -G of p4 (python marshal output) gives more context about the data being output. That's useful when using the command "change -o" as we can distinguish between warning/error line and real change description. Some p4 plugin/hooks in the server side generates some warnings when executed.