Re: [PATCH] git-svn: do not reuse caches memoized for a different architecture

2016-10-27 Thread Eric Wong
Junio C Hamano wrote: > Just peeking from the sideline, but the your squash looks like an > improvement to me. Thanks. > Hopefully the final version after your interaction with Dscho can > come to me via another "pull this now"? Not sure if I'll be online the next few days,

Re: [PATCH] git-svn: do not reuse caches memoized for a different architecture

2016-10-27 Thread Junio C Hamano
Eric Wong writes: > Johannes Schindelin wrote: >> +++ b/perl/Git/SVN.pm >> @@ -1658,6 +1658,11 @@ sub tie_for_persistent_memoization { >> if ($memo_backend > 0) { >> tie %$hash => 'Git::SVN::Memoize::YAML', "$path.yaml"; >> }

Re: [PATCH] git-svn: do not reuse caches memoized for a different architecture

2016-10-25 Thread Eric Wong
Johannes Schindelin wrote: > +++ b/perl/Git/SVN.pm > @@ -1658,6 +1658,11 @@ sub tie_for_persistent_memoization { > if ($memo_backend > 0) { > tie %$hash => 'Git::SVN::Memoize::YAML', "$path.yaml"; > } else { > + # first verify that

[PATCH] git-svn: do not reuse caches memoized for a different architecture

2016-10-25 Thread Johannes Schindelin
From: Gavin Lambert Reusing cached data speeds up git-svn by quite a fair bit. However, if the YAML module is unavailable, the caches are written to disk in an architecture-dependent manner. That leads to problems when upgrading, say, from 32-bit to 64-bit Git for Windows.