Re: [PATCH] git-web--browser: avoid errors in terminal when running Firefox on Windows

2013-01-25 Thread Shumkin Alexey
2013/1/26 Jeff King : > On Fri, Jan 25, 2013 at 06:44:13PM +0400, Alexey Shumkin wrote: > >> test_web_browse () { >> - # browser=$1 url=$2 >> + # browser=$1 url=$2 sleep_timeout=$3 >> + sleep_timeout="$3" >> git web--browse --browser="$1" "$2" >actual && >> + # if $3 is set >

Re: [PATCH] git-web--browser: avoid errors in terminal when running Firefox on Windows

2013-01-25 Thread Jeff King
On Fri, Jan 25, 2013 at 06:44:13PM +0400, Alexey Shumkin wrote: > test_web_browse () { > - # browser=$1 url=$2 > + # browser=$1 url=$2 sleep_timeout=$3 > + sleep_timeout="$3" > git web--browse --browser="$1" "$2" >actual && > + # if $3 is set > + # as far as Firefox is r

Re: [PATCH] git-web--browser: avoid errors in terminal when running Firefox on Windows

2013-01-25 Thread Junio C Hamano
Alexey Shumkin writes: > Firefox on Windows by default is placed in "C:\Program Files\Mozilla Firefox" > folder, i.e. its path contains spaces. Before running this browser > "git-web--browse" > tests version of Firefox to decide whether to use "-new-tab" option or not. > > Quote browser path to

[PATCH] git-web--browser: avoid errors in terminal when running Firefox on Windows

2013-01-25 Thread Alexey Shumkin
Firefox on Windows by default is placed in "C:\Program Files\Mozilla Firefox" folder, i.e. its path contains spaces. Before running this browser "git-web--browse" tests version of Firefox to decide whether to use "-new-tab" option or not. Quote browser path to avoid error during this test. Signe