Re: [PATCH] gitweb.perl: fix %highlight_ext mappings

2012-11-08 Thread Jeff King
On Sun, Nov 04, 2012 at 09:45:55AM -0800, rh wrote: > The previous change created a dictionary of one-to-one elements when > the intent was to map mutliple related types to one main type. > e.g. bash, ksh, zsh, sh all map to sh since they share similar syntax > This makes the mapping as the origin

Re: [PATCH] gitweb.perl: fix %highlight_ext mappings

2012-11-04 Thread Jeff King
On Fri, Nov 02, 2012 at 02:12:26PM -0700, rh wrote: > The previous change created a dictionary of one-to-one elements when > the intent was to map mutliple related types to one main type. > e.g. bash, ksh, zsh, sh all map to sh since they share similar syntax > This makes the mapping as the origin

Re: [PATCH] gitweb.perl: fix %highlight_ext

2012-11-04 Thread Jeff King
On Fri, Nov 02, 2012 at 02:18:09PM -0700, rh wrote: > > I think the patch itself looks OK, but: > > > > 1. It isn't formatted to apply with git-am. Please use > > git-format-patch. > > git format-patch command wouldn't work for me. I can see that you > don't need more stuff to do but not

Re: [PATCH] gitweb.perl: fix %highlight_ext

2012-11-02 Thread Jeff King
On Mon, Oct 29, 2012 at 09:42:07AM -0700, rh wrote: > I also consolidated exts where applicable. > i.e. c and h maps to c > > > -- > > diff --git a/a/gitweb.cgi b/b/gitweb.cgi > index 060db27..155b238 100755 > --- a/a/gitweb.cgi > +++ b/b/gitweb.cgi > @@ -246,19 +246,19 @@ our %highlight_basen

[PATCH] gitweb.perl: fix %highlight_ext

2012-10-29 Thread rh
I also consolidated exts where applicable. i.e. c and h maps to c -- diff --git a/a/gitweb.cgi b/b/gitweb.cgi index 060db27..155b238 100755 --- a/a/gitweb.cgi +++ b/b/gitweb.cgi @@ -246,19 +246,19 @@ our %highlight_basename = ( 'Makefile' => 'make', ); # match by extension + our %hig