Re: [PATCH] grep: correct help string for --exclude-standard

2015-03-04 Thread Jeff King
On Fri, Feb 27, 2015 at 09:01:58PM +0700, Nguyễn Thái Ngọc Duy wrote: The current help string is about --no-exclude-standard. But git grep -h would show --exclude-standard instead. Flip the string. See 0a93fb8 (grep: teach --untracked and --exclude-standard options - 2011-09-27) for more info

Re: [PATCH] grep: correct help string for --exclude-standard

2015-03-04 Thread Duy Nguyen
On Wed, Mar 4, 2015 at 6:26 PM, Jeff King p...@peff.net wrote: It might be nice if parseopt had a PARSE_OPT_NEGHELP option or something to show the --no- form. Regardless, yes it would be nice to have something like this. I think there are places that can make use of this. Grepping

Re: [PATCH] grep: correct help string for --exclude-standard

2015-03-04 Thread Duy Nguyen
On Wed, Mar 4, 2015 at 5:16 PM, Jeff King p...@peff.net wrote: Hmm. If the default is --exclude-standard, then what expect people to use is --no-exclude-standard. Would it make more sense to list that in the -h output? I thought about it and actually edited git-grep man page to clarify the

Re: [PATCH] grep: correct help string for --exclude-standard

2015-03-04 Thread Jeff King
On Wed, Mar 04, 2015 at 06:13:32PM +0700, Duy Nguyen wrote: On Wed, Mar 4, 2015 at 5:16 PM, Jeff King p...@peff.net wrote: Hmm. If the default is --exclude-standard, then what expect people to use is --no-exclude-standard. Would it make more sense to list that in the -h output? I

[PATCH] grep: correct help string for --exclude-standard

2015-02-27 Thread Nguyễn Thái Ngọc Duy
The current help string is about --no-exclude-standard. But git grep -h would show --exclude-standard instead. Flip the string. See 0a93fb8 (grep: teach --untracked and --exclude-standard options - 2011-09-27) for more info about these options. Signed-off-by: Nguyễn Thái Ngọc Duy