Re: [PATCH] index-pack: fix truncation of off_t in comparison

2015-06-04 Thread Junio C Hamano
Jeff King writes: > On top of nd/slim-index-pack-memory-usage, which introduced the bug (but > it is already in master). Thanks. In this round, I decided to deliberately merge more iffy and larger topics to 'master' in early part of the cycle, and it seems to be paying off nicely ;-). Will que

Re: [PATCH] index-pack: fix truncation of off_t in comparison

2015-06-04 Thread Duy Nguyen
On Thu, Jun 4, 2015 at 7:35 PM, Jeff King wrote: > Commit c6458e6 (index-pack: kill union delta_base to save > memory, 2015-04-18) refactored the comparison functions used > in sorting and binary searching our delta list. The > resulting code does something like: > > int cmp_offsets(off_t a, off

[PATCH] index-pack: fix truncation of off_t in comparison

2015-06-04 Thread Jeff King
Commit c6458e6 (index-pack: kill union delta_base to save memory, 2015-04-18) refactored the comparison functions used in sorting and binary searching our delta list. The resulting code does something like: int cmp_offsets(off_t a, off_t b) { return a - b; } This works most of the