Re: [PATCH] list-objects-filter-options: fix up some sparse warnings

2017-11-21 Thread Stefan Beller
> [It would probably be easier if I used git to output this for me, rather > than typing it into my email client!] git config alias.gcs "show --date=short -s --pretty='format:%h ("%s", %ad)'" will make you the `git gcs` alias that I use to describe commits.

Re: [PATCH] list-objects-filter-options: fix up some sparse warnings

2017-11-21 Thread Jeff Hostetler
On 11/20/2017 6:39 PM, Ramsay Jones wrote: In particular, sparse complains that the armor_{en,de}code_arg() functions are 'not declared - should they be static?'. Since the armor_decode_arg() symbol does not require more than file visibility, we can simply mark the declaration with static. The

Re: [PATCH] list-objects-filter-options: fix up some sparse warnings

2017-11-21 Thread Ramsay Jones
On 21/11/17 01:16, Jonathan Nieder wrote: > Hi, > > Ramsay Jones wrote: > >> If you need to re-roll your 'jh/object-filtering' branch, could you >> please squash this (or something like it) into the relevant patch >> (commit bf0aedcbe1, "list-objects: filter objects in traverse_commit_list", >>

Re: [PATCH] list-objects-filter-options: fix up some sparse warnings

2017-11-20 Thread Jonathan Nieder
Hi, Ramsay Jones wrote: > If you need to re-roll your 'jh/object-filtering' branch, could you > please squash this (or something like it) into the relevant patch > (commit bf0aedcbe1, "list-objects: filter objects in traverse_commit_list", > 16-11-2017). Micronit: can these messages use the ISO

[PATCH] list-objects-filter-options: fix up some sparse warnings

2017-11-20 Thread Ramsay Jones
In particular, sparse complains that the armor_{en,de}code_arg() functions are 'not declared - should they be static?'. Since the armor_decode_arg() symbol does not require more than file visibility, we can simply mark the declaration with static. The armor_encode_arg() function has no callers, so