Re: [PATCH] mingw: use OpenSSL's SHA-1 routines

2017-03-02 Thread Junio C Hamano
Johannes Sixt writes: > Am 24.02.2017 um 22:54 schrieb Junio C Hamano: >> Johannes Sixt writes: >>> I'll use the patch for daily work for a while to see whether it hurts. >> >> Please ping this thread again when you have something to add. For >> now, I'll demote this patch from 'next' to 'pu' w

Re: [PATCH] mingw: use OpenSSL's SHA-1 routines

2017-03-01 Thread Johannes Sixt
Am 24.02.2017 um 22:54 schrieb Junio C Hamano: Johannes Sixt writes: I'll use the patch for daily work for a while to see whether it hurts. Please ping this thread again when you have something to add. For now, I'll demote this patch from 'next' to 'pu' when we rewind and rebuild 'next' post

Re: [PATCH] mingw: use OpenSSL's SHA-1 routines

2017-02-24 Thread Linus Torvalds
On Thu, Feb 9, 2017 at 9:02 PM, Jeff King wrote: > > I think this is only half the story. A heavy-sha1 workload is faster, > which is good. But one of the original reasons to prefer blk-sha1 (at > least on Linux) is that resolving libcrypto.so symbols takes a > non-trivial amount of time. I just t

Re: [PATCH] mingw: use OpenSSL's SHA-1 routines

2017-02-24 Thread Junio C Hamano
Johannes Sixt writes: > It can be argued that in normal interactive use, it is hard to notice > that another DLL is loaded. Don't forget, though, that on Windows it > is not only the pure time to resolve the entry points, but also that > typically virus scanners inspect every executable file that

Re: [PATCH] mingw: use OpenSSL's SHA-1 routines

2017-02-16 Thread Johannes Sixt
Am 13.02.2017 um 18:16 schrieb Johannes Schindelin: On Sat, 11 Feb 2017, Johannes Sixt wrote: Am 10.02.2017 um 00:41 schrieb Junio C Hamano: Johannes Schindelin writes: From: Jeff Hostetler Use OpenSSL's SHA-1 routines rather than builtin block-sha1 routines. This improves performance on

Re: [PATCH] mingw: use OpenSSL's SHA-1 routines

2017-02-13 Thread Johannes Sixt
Am 13.02.2017 um 23:38 schrieb Johannes Schindelin: In addition, you build from a custom MINGW/MSys1 setup, correct? Correct. Specifically, I use the build tools from "msysgit" times, but build outside the premanufactured build environement; i.e., the "THIS_IS_MSYSGIT" section in config.mak.u

Re: [PATCH] mingw: use OpenSSL's SHA-1 routines

2017-02-13 Thread Johannes Schindelin
Hi, On Mon, 13 Feb 2017, Johannes Sixt wrote: > Am 13.02.2017 um 20:42 schrieb Junio C Hamano: > > I have been operating under the assumption that everybody on Windows > > who builds Git works off of Dscho's Git for Windows tree, and patches > > that are specific to Windows from Dscho's are sent

Re: [PATCH] mingw: use OpenSSL's SHA-1 routines

2017-02-13 Thread Johannes Sixt
Am 13.02.2017 um 20:42 schrieb Junio C Hamano: I have been operating under the assumption that everybody on Windows who builds Git works off of Dscho's Git for Windows tree, and patches that are specific to Windows from Dscho's are sent to me via the list only after they have been in Git for Wind

Re: [PATCH] mingw: use OpenSSL's SHA-1 routines

2017-02-13 Thread Junio C Hamano
Johannes Sixt writes: > The patch does add a new runtime dependency on libcrypto.dll in my > environment. I would be surprised if it does not also with your modern > build tools. > > I haven't had time to compare test suite runtimes. > >> I'm open to the argument that it doesn't matter in practic

Re: [PATCH] mingw: use OpenSSL's SHA-1 routines

2017-02-13 Thread Johannes Sixt
Am 10.02.2017 um 17:04 schrieb Jeff King: On Fri, Feb 10, 2017 at 04:49:02PM +0100, Johannes Schindelin wrote: I think this is only half the story. A heavy-sha1 workload is faster, which is good. But one of the original reasons to prefer blk-sha1 (at least on Linux) is that resolving libcrypto.

Re: [PATCH] mingw: use OpenSSL's SHA-1 routines

2017-02-13 Thread Johannes Schindelin
Hi Hannes, On Sat, 11 Feb 2017, Johannes Sixt wrote: > Am 10.02.2017 um 00:41 schrieb Junio C Hamano: > > Johannes Schindelin writes: > > > > > From: Jeff Hostetler > > > > > > Use OpenSSL's SHA-1 routines rather than builtin block-sha1 > > > routines. This improves performance on SHA1 operati

Re: [PATCH] mingw: use OpenSSL's SHA-1 routines

2017-02-11 Thread Junio C Hamano
Johannes Sixt writes: > Am 10.02.2017 um 00:41 schrieb Junio C Hamano: >> ... >> Nice. Will queue as jh/mingw-openssl-sha1 topic; it is a bit too >> late for today's integration cycle to be merged to 'next', but let's >> have this by the end of the week in 'master'. > > Please don't rush this th

Re: [PATCH] mingw: use OpenSSL's SHA-1 routines

2017-02-11 Thread Johannes Sixt
Am 10.02.2017 um 00:41 schrieb Junio C Hamano: Johannes Schindelin writes: From: Jeff Hostetler Use OpenSSL's SHA-1 routines rather than builtin block-sha1 routines. This improves performance on SHA1 operations on Intel processors. ... Signed-off-by: Jeff Hostetler Signed-off-by: Johannes

Re: [PATCH] mingw: use OpenSSL's SHA-1 routines

2017-02-10 Thread Jeff King
On Fri, Feb 10, 2017 at 04:49:02PM +0100, Johannes Schindelin wrote: > > I think this is only half the story. A heavy-sha1 workload is faster, > > which is good. But one of the original reasons to prefer blk-sha1 (at > > least on Linux) is that resolving libcrypto.so symbols takes a > > non-trivia

Re: [PATCH] mingw: use OpenSSL's SHA-1 routines

2017-02-10 Thread Johannes Schindelin
Hi Peff, On Fri, 10 Feb 2017, Jeff King wrote: > On Thu, Feb 09, 2017 at 11:27:49PM +0100, Johannes Schindelin wrote: > > > From: Jeff Hostetler > > > > Use OpenSSL's SHA-1 routines rather than builtin block-sha1 routines. > > This improves performance on SHA1 operations on Intel processors. >

Re: [PATCH] mingw: use OpenSSL's SHA-1 routines

2017-02-09 Thread Jeff King
On Thu, Feb 09, 2017 at 11:27:49PM +0100, Johannes Schindelin wrote: > From: Jeff Hostetler > > Use OpenSSL's SHA-1 routines rather than builtin block-sha1 routines. > This improves performance on SHA1 operations on Intel processors. > > OpenSSL 1.0.2 has made considerable performance improveme

Re: [PATCH] mingw: use OpenSSL's SHA-1 routines

2017-02-09 Thread Junio C Hamano
Johannes Schindelin writes: > From: Jeff Hostetler > > Use OpenSSL's SHA-1 routines rather than builtin block-sha1 routines. > This improves performance on SHA1 operations on Intel processors. > ... > > Signed-off-by: Jeff Hostetler > Signed-off-by: Johannes Schindelin > --- Nice. Will queue

[PATCH] mingw: use OpenSSL's SHA-1 routines

2017-02-09 Thread Johannes Schindelin
From: Jeff Hostetler Use OpenSSL's SHA-1 routines rather than builtin block-sha1 routines. This improves performance on SHA1 operations on Intel processors. OpenSSL 1.0.2 has made considerable performance improvements and support the Intel hardware acceleration features. See: https://software.i