Re: [PATCH] oidset: don't return value from oidset_init

2018-01-08 Thread Johannes Sixt
Am 09.01.2018 um 00:26 schrieb Junio C Hamano: Thomas Gummerer writes: c3a9ad3117 ("oidset: add iterator methods to oidset", 2017-11-21) introduced a 'oidset_init()' function in oidset.h, which has void as return type, but returns an expression. ... diff --git a/oidset.h

Re: [PATCH] oidset: don't return value from oidset_init

2018-01-08 Thread Junio C Hamano
Thomas Gummerer writes: > c3a9ad3117 ("oidset: add iterator methods to oidset", 2017-11-21) > introduced a 'oidset_init()' function in oidset.h, which has void as > return type, but returns an expression. > ... > diff --git a/oidset.h b/oidset.h > index

[PATCH] oidset: don't return value from oidset_init

2018-01-07 Thread Thomas Gummerer
c3a9ad3117 ("oidset: add iterator methods to oidset", 2017-11-21) introduced a 'oidset_init()' function in oidset.h, which has void as return type, but returns an expression. This makes the solaris compiler fail with: "oidset.h", line 30: void function cannot return value As the return type