Re: [PATCH] pack-format.txt: more details on pack file format

2018-05-08 Thread Stefan Beller
>>> +Deltified representation >> >> Does this refer to OFS delta as well as REF deltas? > > Yes. Both OFS and REF deltas have the same "body" which is what this > part is about. The differences between OFS and REF deltas are not > described (in fact I don't think we describe what OFS and REF

Re: [PATCH] pack-format.txt: more details on pack file format

2018-05-08 Thread Duy Nguyen
On Tue, May 8, 2018 at 8:21 PM, Ævar Arnfjörð Bjarmason wrote: > > On Tue, May 08 2018, Nguyễn Thái Ngọc Duy wrote: > >> The current document mentions OBJ_* constants without their actual >> values. A git developer would know these are from cache.h but that's >> not very

Re: [PATCH] pack-format.txt: more details on pack file format

2018-05-08 Thread Duy Nguyen
On Tue, May 8, 2018 at 7:23 PM, Stefan Beller wrote: >> While at there, I also add some text about this obscure delta format. >> We occasionally have questions about this on the mailing list if I >> remember correctly. > > Let me see if I can understand it, as I am not well

Re: [PATCH] pack-format.txt: more details on pack file format

2018-05-08 Thread Ævar Arnfjörð Bjarmason
On Tue, May 08 2018, Nguyễn Thái Ngọc Duy wrote: > The current document mentions OBJ_* constants without their actual > values. A git developer would know these are from cache.h but that's > not very friendly to a person who wants to read this file to implement > a pack file parser. > >

Re: [PATCH] pack-format.txt: more details on pack file format

2018-05-08 Thread Stefan Beller
On Tue, May 8, 2018 at 8:56 AM, Nguyễn Thái Ngọc Duy wrote: > The current document mentions OBJ_* constants without their actual > values. A git developer would know these are from cache.h but that's > not very friendly to a person who wants to read this file to implement > a

[PATCH] pack-format.txt: more details on pack file format

2018-05-08 Thread Nguyễn Thái Ngọc Duy
The current document mentions OBJ_* constants without their actual values. A git developer would know these are from cache.h but that's not very friendly to a person who wants to read this file to implement a pack file parser. Similarly, the deltified representation is not documented at all (the