On Sat, 14 Sep 2013, Duy Nguyen wrote:
> On Sat, Sep 14, 2013 at 4:26 AM, Thomas Rast wrote:
> > I tried the perf script below, but at least for the git repo the only
> > thing I can see is noise.
>
> --stdout does not set do_check_packed_object_crc, you need to run
> pack-objects without --stdo
On Sat, Sep 14, 2013 at 4:26 AM, Thomas Rast wrote:
> Junio C Hamano writes:
>
>> Nguyễn Thái Ngọc Duy writes:
>>
>>> Current code makes pack-objects always do check_pack_crc() in
>>> unpack_entry() even if right after that we find out there's a cached
>>> version and pack access is not needed.
Junio C Hamano writes:
> Nguyễn Thái Ngọc Duy writes:
>
>> Current code makes pack-objects always do check_pack_crc() in
>> unpack_entry() even if right after that we find out there's a cached
>> version and pack access is not needed. Swap two code blocks, search
>> for cached version first, the
Nguyễn Thái Ngọc Duy writes:
> Current code makes pack-objects always do check_pack_crc() in
> unpack_entry() even if right after that we find out there's a cached
> version and pack access is not needed. Swap two code blocks, search
> for cached version first, then check crc.
>
> Signed-off-by:
Current code makes pack-objects always do check_pack_crc() in
unpack_entry() even if right after that we find out there's a cached
version and pack access is not needed. Swap two code blocks, search
for cached version first, then check crc.
Signed-off-by: Nguyễn Thái Ngọc Duy
---
sha1_file.c | 2
5 matches
Mail list logo
