Re: [PATCH] pack-protocol: document newline behavior in push commands

On Thu, Sep 03, 2015 at 03:17:18PM -0700, Junio C Hamano wrote: > Jeff King writes: > > > Frankly, this feels a bit like a step backwards to me. I am tempted to > > suggest instead that git start sending the newlines, but I'm not sure > > it's worth any potential fallout. > > I

Re: [PATCH] pack-protocol: document newline behavior in push commands

Jeff King writes: > Right, it was the second "we know..." that made me worry. It is really > "we assume". :) Whether it is right according to the spec or not, the > real world is sometimes more complicated. And given that there is no > real advantage to changing the sending

[PATCH] pack-protocol: document newline behavior in push commands

Our pack-protocol spec indicates that a pushing client should send ref update commands like: $old_sha1 $new_sha1 $ref\n with each ref update in its own pktline, with a trailing newline. However, git itself does not follow this behavior; it omits the trailing newline. For the most part the

Re: [PATCH] pack-protocol: document newline behavior in push commands

Jeff King writes: > Frankly, this feels a bit like a step backwards to me. I am tempted to > suggest instead that git start sending the newlines, but I'm not sure > it's worth any potential fallout. I actually think we should do both in the longer term. If we say sender "SHOULD"