Re: [PATCH] read-cache.c: fix a sparse warning

2018-09-17 Thread Ramsay Jones
On 17/09/18 17:27, Ramsay Jones wrote: > > > On 17/09/18 15:15, Ben Peart wrote: >> >> >> On 9/16/2018 3:17 AM, Eric Sunshine wrote: >>> On Fri, Sep 14, 2018 at 7:29 PM Ramsay Jones >>> wrote: At one time, the POSIX standard required the type used to represent a thread handle

Re: [PATCH] read-cache.c: fix a sparse warning

2018-09-17 Thread Ramsay Jones
On 17/09/18 15:15, Ben Peart wrote: > > > On 9/16/2018 3:17 AM, Eric Sunshine wrote: >> On Fri, Sep 14, 2018 at 7:29 PM Ramsay Jones >> wrote: >>> At one time, the POSIX standard required the type used to represent >>> a thread handle (pthread_t) be an arithmetic type. This is no longer >>>

Re: [PATCH] read-cache.c: fix a sparse warning

2018-09-17 Thread Ben Peart
On 9/16/2018 3:17 AM, Eric Sunshine wrote: On Fri, Sep 14, 2018 at 7:29 PM Ramsay Jones wrote: At one time, the POSIX standard required the type used to represent a thread handle (pthread_t) be an arithmetic type. This is no longer the case, probably because different platforms used to

Re: [PATCH] read-cache.c: fix a sparse warning

2018-09-16 Thread Eric Sunshine
On Fri, Sep 14, 2018 at 7:29 PM Ramsay Jones wrote: > At one time, the POSIX standard required the type used to represent > a thread handle (pthread_t) be an arithmetic type. This is no longer > the case, probably because different platforms used to regularly > ignore that requirement. For

[PATCH] read-cache.c: fix a sparse warning

2018-09-14 Thread Ramsay Jones
At one time, the POSIX standard required the type used to represent a thread handle (pthread_t) be an arithmetic type. This is no longer the case, probably because different platforms used to regularly ignore that requirement. For example, on cygwin a pthread_t is a pointer to a structure (a