Re: [PATCH] rebase -i: respect to core.abbrev

2013-09-30 Thread Jonathan Nieder
Kirill A. Shutemov wrote: > collapse_todo_ids() uses `git rev-parse --short=7' to abbrev commit ids. > Let's drop argument from --short to use default (7) or config value > instead. Since the todo ids are expanded immediately after the editor exits, there is not much risk of accidental hash colli

Re: [PATCH] rebase -i: respect to core.abbrev

2013-09-28 Thread Eric Sunshine
On Sat, Sep 28, 2013 at 5:10 PM, Kirill A. Shutemov wrote: > collapse_todo_ids() uses `git rev-parse --short=7' to abbrev commit ids. > Let's drop argument from --short to use default (7) or config value > instead. > > Signed-off-by: Kirill A. Shutemov > --- > git-rebase--interactive.sh | 2 +- >

RE: [PATCH] rebase -i: respect to core.abbrev

2013-09-28 Thread Kirill A. Shutemov
> - transform_todo_ids --short=7 > + abbrev="$(git config --get 'core.abbrev')" > + transform_todo_ids --short="${abbrev:-7}" Simpler version is below. >From 933a4159f0c037a37f3b251a4f13deea7f17b6c3 Mon Sep 17 00:00:00 2001 From: "Kiri

[PATCH] rebase -i: respect to core.abbrev

2013-09-28 Thread Kirill A. Shutemov
git rebase -i collapses ids on todo list to 7 hexdigits. Let's use core.abbrev config option instead, if it's set. Signed-off-by: Kirill A. Shutemov --- git-rebase--interactive.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/git-rebase--interactive.sh b/git-rebase--inter