Re: [PATCH] remote-curl: fall back to Basic auth if Negotiate fails.

2015-01-05 Thread Dan Langille (dalangil)
On Dec 26, 2014, at 11:01 PM, brian m. carlson sand...@crustytoothpaste.net wrote: Apache servers using mod_auth_kerb can be configured to allow the user to authenticate either using Negotiate (using the Kerberos ticket) or Basic authentication (using the Kerberos password). Often, one

Re: [PATCH] remote-curl: fall back to Basic auth if Negotiate fails.

2014-12-27 Thread Jeff King
On Sat, Dec 27, 2014 at 04:01:33AM +, brian m. carlson wrote: Apache servers using mod_auth_kerb can be configured to allow the user to authenticate either using Negotiate (using the Kerberos ticket) or Basic authentication (using the Kerberos password). Often, one will want to use

Re: [PATCH] remote-curl: fall back to Basic auth if Negotiate fails.

2014-12-27 Thread brian m. carlson
On Sat, Dec 27, 2014 at 12:56:04PM -0500, Jeff King wrote: On Sat, Dec 27, 2014 at 04:01:33AM +, brian m. carlson wrote: Apache servers using mod_auth_kerb can be configured to allow the user to authenticate either using Negotiate (using the Kerberos ticket) or Basic authentication

Re: [PATCH] remote-curl: fall back to Basic auth if Negotiate fails.

2014-12-27 Thread Jeff King
On Sat, Dec 27, 2014 at 09:09:36PM +, brian m. carlson wrote: I'm not familiar enough with Negotiate auth to do give a thorough review on the logic above. But FWIW, it makes sense to me, and the code looks correct. libcurl will try very hard to use something other than Basic auth,

Re: [PATCH] remote-curl: fall back to Basic auth if Negotiate fails.

2014-12-27 Thread brian m. carlson
On Sat, Dec 27, 2014 at 04:29:49PM -0500, Jeff King wrote: since if they failed the first time, they will never succeed Are there other GSSAPI methods where this is not the case? I don't know of any, and AFAICT git's support is used only for Kerberos, so this is probably safe for now. If

[PATCH] remote-curl: fall back to Basic auth if Negotiate fails.

2014-12-26 Thread brian m. carlson
Apache servers using mod_auth_kerb can be configured to allow the user to authenticate either using Negotiate (using the Kerberos ticket) or Basic authentication (using the Kerberos password). Often, one will want to use Negotiate authentication if it is available, but fall back to Basic