Re: [PATCH] repository: fix a sparse 'using integer as NULL pointer' warning

2017-11-29 Thread Ramsay Jones
On 29/11/17 01:35, brian m. carlson wrote: > On Tue, Nov 28, 2017 at 03:01:19AM +, Ramsay Jones wrote: >> >> Commit 78a6766802 ("Integrate hash algorithm support with repo setup", >> 2017-11-12) added a 'const struct git_hash_algo *hash_algo' field to the >> repository structure, without

Re: [PATCH] repository: fix a sparse 'using integer as NULL pointer' warning

2017-11-28 Thread brian m. carlson
On Tue, Nov 28, 2017 at 03:01:19AM +, Ramsay Jones wrote: > > Commit 78a6766802 ("Integrate hash algorithm support with repo setup", > 2017-11-12) added a 'const struct git_hash_algo *hash_algo' field to the > repository structure, without modifying the initializer of the 'the_repo' >

Re: [PATCH] repository: fix a sparse 'using integer as NULL pointer' warning

2017-11-27 Thread Junio C Hamano
Ramsay Jones writes: > Hi Junio, > > I don't recall Brian doing a re-roll of the 'bc/hash-algo' branch[1], but > now that it has been merged into the 'next' branch, sparse is barking on > that branch too. This patch (slightly different to the last one) applies > on

[PATCH] repository: fix a sparse 'using integer as NULL pointer' warning

2017-11-27 Thread Ramsay Jones
Commit 78a6766802 ("Integrate hash algorithm support with repo setup", 2017-11-12) added a 'const struct git_hash_algo *hash_algo' field to the repository structure, without modifying the initializer of the 'the_repo' variable. This does not actually introduce a bug, since the '0' initializer for

Re: [PATCH] repository: fix a sparse 'using integer a NULL pointer' warning

2017-08-22 Thread Junio C Hamano
René Scharfe writes: >> diff --git a/repository.c b/repository.c >> index 01af20dee..ceef73614 100644 >> --- a/repository.c >> +++ b/repository.c >> @@ -5,7 +5,7 @@ >> >> /* The main repository */ >> static struct repository the_repo = { >> -NULL, NULL, NULL, NULL, NULL,

Re: [PATCH] repository: fix a sparse 'using integer a NULL pointer' warning

2017-08-22 Thread René Scharfe
Am 21.08.2017 um 17:48 schrieb Ramsay Jones: > > Commit 67a9dfcc00 ("hash-algo: integrate hash algorithm support with > repo setup", 21-08-2017) added a 'const struct git_hash_algo *hash_algo' > field to the repository structure, without modifying the initializer > of the 'the_repo' variable.

Re: [PATCH] repository: fix a sparse 'using integer a NULL pointer' warning

2017-08-21 Thread brian m. carlson
On Mon, Aug 21, 2017 at 04:48:42PM +0100, Ramsay Jones wrote: > > Commit 67a9dfcc00 ("hash-algo: integrate hash algorithm support with > repo setup", 21-08-2017) added a 'const struct git_hash_algo *hash_algo' > field to the repository structure, without modifying the initializer > of the

[PATCH] repository: fix a sparse 'using integer a NULL pointer' warning

2017-08-21 Thread Ramsay Jones
Commit 67a9dfcc00 ("hash-algo: integrate hash algorithm support with repo setup", 21-08-2017) added a 'const struct git_hash_algo *hash_algo' field to the repository structure, without modifying the initializer of the 'the_repo' variable. This does not actually introduce a bug, since the '0'