Re: [PATCH] run-command.c: print env vars when GIT_TRACE is set

2018-01-11 Thread Johannes Sixt
Am 11.01.2018 um 11:07 schrieb Jeff King: The output for a single command is pretty shell-like due to the quoting: $ GIT_TRACE=1 ./git upload-pack . >/dev/null [...]run_command: 'git-upload-pack' '.' You could copy and paste that to a shell if you wanted. And with environment variables,

Re: [PATCH] run-command.c: print env vars when GIT_TRACE is set

2018-01-11 Thread Duy Nguyen
On Thu, Jan 11, 2018 at 5:07 PM, Jeff King wrote: > On Wed, Jan 10, 2018 at 05:48:35PM +0700, Nguyễn Thái Ngọc Duy wrote: > >> Occasionally submodule code could execute new commands with GIT_DIR set >> to some submodule. GIT_TRACE prints just the command line which makes it >> hard

Re: [PATCH] run-command.c: print env vars when GIT_TRACE is set

2018-01-11 Thread Jeff King
On Wed, Jan 10, 2018 at 05:48:35PM +0700, Nguyễn Thái Ngọc Duy wrote: > Occasionally submodule code could execute new commands with GIT_DIR set > to some submodule. GIT_TRACE prints just the command line which makes it > hard to tell that it's not really executed on this repository. > > Print

Re: [PATCH] run-command.c: print env vars when GIT_TRACE is set

2018-01-10 Thread Stefan Beller
On Wed, Jan 10, 2018 at 11:26 AM, Brandon Williams wrote: > On 01/10, Stefan Beller wrote: >> On Wed, Jan 10, 2018 at 10:09 AM, Brandon Williams wrote: >> > At first when i read this I was under the impression that the whole >> > environment was going to be

Re: [PATCH] run-command.c: print env vars when GIT_TRACE is set

2018-01-10 Thread Brandon Williams
On 01/10, Stefan Beller wrote: > On Wed, Jan 10, 2018 at 10:09 AM, Brandon Williams wrote: > > At first when i read this I was under the impression that the whole > > environment was going to be printed out...but i now realize that this > > tracing will only print out the

Re: [PATCH] run-command.c: print env vars when GIT_TRACE is set

2018-01-10 Thread Stefan Beller
On Wed, Jan 10, 2018 at 10:09 AM, Brandon Williams wrote: > On 01/10, Nguyễn Thái Ngọc Duy wrote: >> Occasionally submodule code could execute new commands with GIT_DIR set >> to some submodule. GIT_TRACE prints just the command line which makes it >> hard to tell that it's not

Re: [PATCH] run-command.c: print env vars when GIT_TRACE is set

2018-01-10 Thread Brandon Williams
On 01/10, Nguyễn Thái Ngọc Duy wrote: > Occasionally submodule code could execute new commands with GIT_DIR set > to some submodule. GIT_TRACE prints just the command line which makes it > hard to tell that it's not really executed on this repository. > > Print env variables in this case. Note

[PATCH] run-command.c: print env vars when GIT_TRACE is set

2018-01-10 Thread Nguyễn Thái Ngọc Duy
Occasionally submodule code could execute new commands with GIT_DIR set to some submodule. GIT_TRACE prints just the command line which makes it hard to tell that it's not really executed on this repository. Print env variables in this case. Note that the code deliberately ignore variables