Re: [PATCH] sequencer: use configured comment character

2018-06-29 Thread Junio C Hamano
Johannes Schindelin writes: > In short: the code is fine, but yes, I had to convince myself by looking > through the code. (Hinting at a possible improvement of the commit > message.) Yup, that exactly was what I was hoping readers to realize.

Re: [PATCH] sequencer: use configured comment character

2018-06-29 Thread Johannes Schindelin
Hi Junio, On Thu, 28 Jun 2018, Junio C Hamano wrote: > Aaron Schrab writes: > > > Use configured comment character when generating comments about branches > > in an instruction sheet. Failure to honor this configuration causes a > > failure to parse the resulting instruction sheet. > > > >

Re: [PATCH] sequencer: use configured comment character

2018-06-28 Thread Junio C Hamano
Aaron Schrab writes: > Use configured comment character when generating comments about branches > in an instruction sheet. Failure to honor this configuration causes a > failure to parse the resulting instruction sheet. > > Signed-off-by: Aaron Schrab > --- > sequencer.c | 2 +- > 1 file

Re: [PATCH] sequencer: use configured comment character

2018-06-28 Thread Johannes Schindelin
Hi Aaron, On Wed, 27 Jun 2018, Aaron Schrab wrote: > Use configured comment character when generating comments about branches > in an instruction sheet. Failure to honor this configuration causes a > failure to parse the resulting instruction sheet. Good catch. Now, if you can refer to the

[PATCH] sequencer: use configured comment character

2018-06-27 Thread Aaron Schrab
Use configured comment character when generating comments about branches in an instruction sheet. Failure to honor this configuration causes a failure to parse the resulting instruction sheet. Signed-off-by: Aaron Schrab --- sequencer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)