Re: [PATCH] status: show progress bar if refreshing the index takes too long

2018-09-07 Thread Eric Sunshine
On Fri, Sep 7, 2018 at 4:29 PM Derrick Stolee wrote: > On 9/7/2018 1:38 PM, Eric Sunshine wrote: > > On Fri, Sep 7, 2018 at 11:51 AM Nguyễn Thái Ngọc Duy > > wrote: > >> + if (progress) > >> + display_progress(progress, i); > >> + if (progress) > >> +

Re: [PATCH] status: show progress bar if refreshing the index takes too long

2018-09-07 Thread Derrick Stolee
On 9/7/2018 1:38 PM, Eric Sunshine wrote: On Fri, Sep 7, 2018 at 11:51 AM Nguyễn Thái Ngọc Duy wrote: Refreshing the index is usually very fast, but it can still take a long time sometimes. Cold cache is one, or something else silly (*). In this case, it's good to show something to let the

Re: [PATCH] status: show progress bar if refreshing the index takes too long

2018-09-07 Thread Eric Sunshine
On Fri, Sep 7, 2018 at 11:51 AM Nguyễn Thái Ngọc Duy wrote: > Refreshing the index is usually very fast, but it can still take a > long time sometimes. Cold cache is one, or something else silly (*). > In this case, it's good to show something to let the user know "git > status" is not hanging,

[PATCH] status: show progress bar if refreshing the index takes too long

2018-09-07 Thread Nguyễn Thái Ngọc Duy
Refreshing the index is usually very fast, but it can still take a long time sometimes. Cold cache is one, or something else silly (*). In this case, it's good to show something to let the user know "git status" is not hanging, it's just busy doing something. (*) I got called by my colleague