Re: [PATCH] string-list: remove unused function print_string_list

2018-09-11 Thread Junio C Hamano
Stefan Beller writes: >> >> >> >> [1] >> >> https://public-inbox.org/git/1421343725-3973-1-git-send-email-kuleshovm...@gmail.com/ >> >> Signed-off-by: Stefan Beller >> > >> > I'll add a blank line before the sign-off. Is this an example that >> > our "where is the existing trailer?" code misbe

Re: [PATCH] string-list: remove unused function print_string_list

2018-09-11 Thread Stefan Beller
On Tue, Sep 11, 2018 at 12:31 PM Junio C Hamano wrote: > > Junio C Hamano writes: > > > Stefan Beller writes: > > > >> The helper function stayed unused for 3 years. A removal of that function > > > > I think it stayed unused for more than that before the previous > > proposal to remove it was w

Re: [PATCH] string-list: remove unused function print_string_list

2018-09-11 Thread Junio C Hamano
Junio C Hamano writes: > Stefan Beller writes: > >> The helper function stayed unused for 3 years. A removal of that function > > I think it stayed unused for more than that before the previous > proposal to remove it was written (I do not bother going back to my > earlier message that identifie

Re: [PATCH] string-list: remove unused function print_string_list

2018-09-11 Thread Junio C Hamano
Stefan Beller writes: > The helper function stayed unused for 3 years. A removal of that function I think it stayed unused for more than that before the previous proposal to remove it was written (I do not bother going back to my earlier message that identified which exact commit this was introd

[PATCH] string-list: remove unused function print_string_list

2018-09-11 Thread Stefan Beller
The helper function stayed unused for 3 years. A removal of that function was proposed before[1], but now time has proven we really do not need the function. [1] https://public-inbox.org/git/1421343725-3973-1-git-send-email-kuleshovm...@gmail.com/ Signed-off-by: Stefan Beller --- string-list.c