Re: [PATCH] submodule: avoid sentence-lego in translated string

2017-10-10 Thread Martin Ågren
On 10 October 2017 at 04:35, Changwoo Ryu wrote: > 2017-10-10 10:26 GMT+09:00 Junio C Hamano : >> Jean-Noël AVILA writes: >> >>> On Monday, 9 October 2017, 09:47:26 CEST Stefan Beller wrote: >>> I always assumed that translators are

Re: [PATCH] submodule: avoid sentence-lego in translated string

2017-10-09 Thread Changwoo Ryu
2017-10-10 10:26 GMT+09:00 Junio C Hamano : > Jean-Noël AVILA writes: > >> On Monday, 9 October 2017, 09:47:26 CEST Stefan Beller wrote: >> >>> I always assumed that translators are aware of these issues and sort of >>> work around this somehow, maybe like

Re: [PATCH] submodule: avoid sentence-lego in translated string

2017-10-09 Thread Junio C Hamano
Jean-Noël AVILA writes: > On Monday, 9 October 2017, 09:47:26 CEST Stefan Beller wrote: > >> I always assumed that translators are aware of these issues and sort of >> work around this somehow, maybe like this: >> >> "submodule entry '%s' (%s) is not a commit. It is of type

Re: [PATCH] submodule: avoid sentence-lego in translated string

2017-10-09 Thread Jean-Noël AVILA
On Monday, 9 October 2017, 09:47:26 CEST Stefan Beller wrote: > I always assumed that translators are aware of these issues and sort of > work around this somehow, maybe like this: > > "submodule entry '%s' (%s) is not a commit. It is of type %s" Translators can be aware of the issue if the

Re: [PATCH] submodule: avoid sentence-lego in translated string

2017-10-09 Thread Stefan Beller
On Sun, Oct 8, 2017 at 9:14 PM, Martin Ågren wrote: > In this particular case, we could have three specific messages plus one > default > message (which at the time shouldn't ever occur). Or we have one specific > message for the "tag"-case, which seems to have been

Re: [PATCH] submodule: avoid sentence-lego in translated string

2017-10-08 Thread Martin Ågren
On 9 October 2017 at 03:30, Junio C Hamano wrote: > On Mon, Oct 9, 2017 at 9:51 AM, brian m. carlson > wrote: >> On Sun, Oct 08, 2017 at 10:32:35AM +0100, Philip Oakley wrote: >>> From: "Martin Ågren" >>> > -

Re: [PATCH] submodule: avoid sentence-lego in translated string

2017-10-08 Thread Junio C Hamano
On Mon, Oct 9, 2017 at 9:51 AM, brian m. carlson wrote: > On Sun, Oct 08, 2017 at 10:32:35AM +0100, Philip Oakley wrote: >> From: "Martin Ågren" >> > - die(_("submodule entry '%s' (%s) is a %s, not a commit"), >> > - cb->path,

Re: [PATCH] submodule: avoid sentence-lego in translated string

2017-10-08 Thread brian m. carlson
On Sun, Oct 08, 2017 at 10:32:35AM +0100, Philip Oakley wrote: > From: "Martin Ågren" > > - die(_("submodule entry '%s' (%s) is a %s, not a commit"), > > - cb->path, oid_to_hex(oid), typename(type)); > > + die(_("submodule entry '%s' (%s) is not a commit"), > > +

Re: [PATCH] submodule: avoid sentence-lego in translated string

2017-10-08 Thread Martin Ågren
On 8 October 2017 at 11:32, Philip Oakley wrote: > From: "Martin Ågren" > >> We currently build an error message like "entry is a %s, not a commit", >> where the placeholder will be replaced with "blob", "tag" or "tree". >> Apart from those three

Re: [PATCH] submodule: avoid sentence-lego in translated string

2017-10-08 Thread Philip Oakley
From: "Martin Ågren" We currently build an error message like "entry is a %s, not a commit", where the placeholder will be replaced with "blob", "tag" or "tree". Apart from those three placeholder words not being translated, in some languages it might be awkward or

[PATCH] submodule: avoid sentence-lego in translated string

2017-10-08 Thread Martin Ågren
We currently build an error message like "entry is a %s, not a commit", where the placeholder will be replaced with "blob", "tag" or "tree". Apart from those three placeholder words not being translated, in some languages it might be awkward or impossible to ensure a grammatically correct end