Re: [PATCH] submodule--helper: don't print null in 'submodule status'

2018-04-18 Thread Junio C Hamano
Stefan Beller writes: > Hi Nguyễn, > > On Wed, Apr 18, 2018 at 7:53 AM, Nguyễn Thái Ngọc Duy > wrote: >> The function compute_rev_name() can return NULL sometimes (e.g. right >> after 'submodule init'). The current code makes 'submodule status' >> print this: >> >> 19d97bf5af05312267c2e874ee6b

Re: [PATCH] submodule--helper: don't print null in 'submodule status'

2018-04-18 Thread Stefan Beller
Hi Nguyễn, On Wed, Apr 18, 2018 at 7:53 AM, Nguyễn Thái Ngọc Duy wrote: > The function compute_rev_name() can return NULL sometimes (e.g. right > after 'submodule init'). The current code makes 'submodule status' > print this: > > 19d97bf5af05312267c2e874ee6bcf584d9e9681 sha1collisiondetection (

[PATCH] submodule--helper: don't print null in 'submodule status'

2018-04-18 Thread Nguyễn Thái Ngọc Duy
The function compute_rev_name() can return NULL sometimes (e.g. right after 'submodule init'). The current code makes 'submodule status' print this: 19d97bf5af05312267c2e874ee6bcf584d9e9681 sha1collisiondetection ((null)) This ugly 'null' adds no value to the user using this command. More import