Re: [PATCH] t: handle EOF in test_copy_bytes()

On Sun, Jul 16, 2017 at 01:10:50PM +0200, René Scharfe wrote: > > And I was pleased to see that after setting OPENSSL_SHA1, the answer to > > "how far" is "we are there". Yay. > > True with GCC, but not with Clang 3.9. A patch for alignment issues in > dir.c is coming up.. Good to know that

Re: [PATCH] t: handle EOF in test_copy_bytes()

Am 16.07.2017 um 12:47 schrieb Jeff King: On Sun, Jul 16, 2017 at 06:45:32AM -0400, Jeff King wrote: I was playing with SANITIZE=undefined after René's patches to see how far we had left to go. I forgot to turn off sha1dc, which causes most programs to die due to the unaligned loads. That

Re: [PATCH] t: handle EOF in test_copy_bytes()

On Sun, Jul 16, 2017 at 06:45:32AM -0400, Jeff King wrote: > I was playing with SANITIZE=undefined after René's patches to see how > far we had left to go. I forgot to turn off sha1dc, which causes most > programs to die due to the unaligned loads. That means git-archive in > t5000 generates no

[PATCH] t: handle EOF in test_copy_bytes()

The test_copy_bytes() function claims to read up to N bytes, or until it gets EOF. But we never handle EOF in our loop, and a short input will cause perl to go into an infinite loop of read() getting zero bytes. Signed-off-by: Jeff King --- I was playing with SANITIZE=undefined