Re: [PATCH] t: use common $SQ variable

2019-09-05 Thread Denton Liu
I should've noted earlier that this patch applies cleanly on top of the "jc/tests-use-lf-from-test-lib" branch. On Thu, Sep 05, 2019 at 03:10:05PM -0700, Denton Liu wrote: > In many test scripts, there are bespoke definitions of the single quote > that are some variation of this: > > SQ="'" >

Re: [PATCH] t: use common $SQ variable

2019-09-05 Thread Taylor Blau
On Thu, Sep 05, 2019 at 06:25:26PM -0400, Taylor Blau wrote: > On Thu, Sep 05, 2019 at 03:10:05PM -0700, Denton Liu wrote: > > In many test scripts, there are bespoke definitions of the single quote > > that are some variation of this: > > > > SQ="'" > > > > Define a common $SQ variable in test

Re: [PATCH] t: use common $SQ variable

2019-09-05 Thread Taylor Blau
On Thu, Sep 05, 2019 at 03:10:05PM -0700, Denton Liu wrote: > In many test scripts, there are bespoke definitions of the single quote > that are some variation of this: > > SQ="'" > > Define a common $SQ variable in test-lib.sh and replace all usages of > these bespoke variables with the common

[PATCH] t: use common $SQ variable

2019-09-05 Thread Denton Liu
In many test scripts, there are bespoke definitions of the single quote that are some variation of this: SQ="'" Define a common $SQ variable in test-lib.sh and replace all usages of these bespoke variables with the common one. This change was done by running `git grep =\"\'\" t/` and `git gr