Re: [PATCH] t1002: stop using sum(1)

2017-08-15 Thread René Scharfe
Am 15.08.2017 um 02:46 schrieb Jonathan Nieder: > Hi, > > René Scharfe wrote: >> We already compare changed files with their expected new contents using >> diff(1), so we don't need to check with "test_must_fail test_cmp" if >> they differ from their original state. A later patch could convert t

Re: [PATCH] t1002: stop using sum(1)

2017-08-15 Thread René Scharfe
Am 14.08.2017 um 22:16 schrieb René Scharfe: > sum(1) is a command for calculating checksums of the contents of files. > It was part of early editions of Unix ("Research Unix", 1972/1973, [1]). > cksum(1) appeared in 4.4BSD (1993) as a replacement [2], and became part > of POSIX.1-2008 [3]. OpenBS

Re: [PATCH] t1002: stop using sum(1)

2017-08-14 Thread Johannes Sixt
Am 15.08.2017 um 02:46 schrieb Jonathan Nieder: Hi, René Scharfe wrote: sum(1) is a command for calculating checksums of the contents of files. It was part of early editions of Unix ("Research Unix", 1972/1973, [1]). cksum(1) appeared in 4.4BSD (1993) as a replacement [2], and became part of P

Re: [PATCH] t1002: stop using sum(1)

2017-08-14 Thread Jonathan Nieder
Hi, René Scharfe wrote: > sum(1) is a command for calculating checksums of the contents of files. > It was part of early editions of Unix ("Research Unix", 1972/1973, [1]). > cksum(1) appeared in 4.4BSD (1993) as a replacement [2], and became part > of POSIX.1-2008 [3]. OpenBSD 5.6 (2014) remove

Re: [PATCH] t1002: stop using sum(1)

2017-08-14 Thread Junio C Hamano
René Scharfe writes: > It's more convenient because it shows differences nicely, it's faster on > MinGW because we have a special implementation there based only on > shell-internal commands,... This made me wonder why we are not using that "faster" one everywhere, but it turns out that it depen

[PATCH] t1002: stop using sum(1)

2017-08-14 Thread René Scharfe
sum(1) is a command for calculating checksums of the contents of files. It was part of early editions of Unix ("Research Unix", 1972/1973, [1]). cksum(1) appeared in 4.4BSD (1993) as a replacement [2], and became part of POSIX.1-2008 [3]. OpenBSD 5.6 (2014) removed sum(1). We only use sum(1) in t