Re: [PATCH] t1402: work around shell quoting issue on NetBSD

2013-01-08 Thread Greg Troxel
René Scharfe writes: > The test fails for me on NetBSD 6.0.1 and reports: > > ok 1 - ref name '' is invalid > ok 2 - ref name '/' is invalid > ok 3 - ref name '/' is invalid with options --allow-onelevel > ok 4 - ref name '/' is invalid with options --normalize > er

Re: [PATCH] t1402: work around shell quoting issue on NetBSD

2013-01-08 Thread Greg Troxel
René Scharfe writes: > invalid_ref() constructs a test case description using its last argument, > but the shell seems to split it up into two pieces if it contains a > space. Minimal test case: This is indeed a bug in NetBSD's shell, which I reported after finding this test case problem, and

Re: [PATCH] t1402: work around shell quoting issue on NetBSD

2013-01-08 Thread Junio C Hamano
René Scharfe writes: > A quick check shows that subtests 64-68 and 89-93 of t0008 fail for me > on Debian (10 in total) and subtests 64 and 89 fail on NetBSD (2 in > total). Unlike t1402 they don't report "bug in the test script". > > t0008 only uses ${:+} substitution on variables that don't co

Re: [PATCH] t1402: work around shell quoting issue on NetBSD

2013-01-08 Thread René Scharfe
Am 08.01.2013 21:39, schrieb Junio C Hamano: René Scharfe writes: # on NetBSD with /bin/sh $ a() { echo $#-$1-$2; } $ t="x"; a "${t:+$t}" 1-x- $ t="x y"; a "${t:+$t}" 2-x-y $ t="x y"; a "${t:+x y}" 1-x y- # and with bash

Re: [PATCH] t1402: work around shell quoting issue on NetBSD

2013-01-08 Thread Junio C Hamano
René Scharfe writes: > The test fails for me on NetBSD 6.0.1 and reports: > > ok 1 - ref name '' is invalid > ok 2 - ref name '/' is invalid > ok 3 - ref name '/' is invalid with options --allow-onelevel > ok 4 - ref name '/' is invalid with options --normalize > err

[PATCH] t1402: work around shell quoting issue on NetBSD

2013-01-08 Thread René Scharfe
The test fails for me on NetBSD 6.0.1 and reports: ok 1 - ref name '' is invalid ok 2 - ref name '/' is invalid ok 3 - ref name '/' is invalid with options --allow-onelevel ok 4 - ref name '/' is invalid with options --normalize error: bug in the test script