Re: [PATCH] t2028: fix minor error and issues in newly-added "worktree move" tests

On Mon, Mar 5, 2018 at 1:37 PM, Junio C Hamano wrote: > SZEDER Gábor writes: > >> Could you please save 'git worktree's output into an intermediate >> file, and run 'grep' on the file's contents? > > Here is what I tentatively came up with, while deciding

Re: [PATCH] t2028: fix minor error and issues in newly-added "worktree move" tests

SZEDER Gábor writes: > There is one more issue in these tests. > ... > The main purpose of this test script is to test the 'git worktree' > command, but these pipes hide its exit code. > Could you please save 'git worktree's output into an intermediate > file, and run

Re: [PATCH] t2028: fix minor error and issues in newly-added "worktree move" tests

> Recently-added "git worktree move" tests include a minor error and a few > small issues. Specifically: > > * checking non-existence of wrong file ("source" instead of > "destination") > > * unneeded redirect (">empty") > > * unused variable ("toplevel") > > * restoring a worktree location

Re: [PATCH] t2028: fix minor error and issues in newly-added "worktree move" tests

On Sun, Mar 4, 2018 at 12:26 PM, Eric Sunshine wrote: > Recently-added "git worktree move" tests include a minor error and a few > small issues. Specifically: > > * checking non-existence of wrong file ("source" instead of > "destination") > > * unneeded redirect

[PATCH] t2028: fix minor error and issues in newly-added "worktree move" tests

Recently-added "git worktree move" tests include a minor error and a few small issues. Specifically: * checking non-existence of wrong file ("source" instead of "destination") * unneeded redirect (">empty") * unused variable ("toplevel") * restoring a worktree location by means of a separate