On Mon, Sep 10, 2018 at 10:18:34AM -0400, Taylor Blau wrote:
> Signed-off-by: Taylor Blau
Oops, this should be:
Reviewed-by: Taylor Blau
Thanks,
Taylor
On Mon, Sep 10, 2018 at 09:19:32PM +0200, SZEDER Gábor wrote:
> > I'd have thought that anybody
> > adding index-specific tracing would do it as GIT_TRACE_INDEX.
>
> Depends on the purpose, I guess. For tracing that is aimed to become
> part of in git, definitely. However, for my own ad-hoc tra
On Mon, Sep 10, 2018 at 11:44:54AM -0400, Jeff King wrote:
> On Mon, Sep 10, 2018 at 04:07:14PM +0200, SZEDER Gábor wrote:
>
> > The test 'add -p does not expand argument lists' in
> > 't3701-add-interactive.sh', added in 7288e12cce (add--interactive: do
> > not expand pathspecs with ls-files, 201
Jeff King writes:
> Not that I'm totally opposed to your patch, but it's a little sad that
> we have to match the specific text used in GIT_TRACE now (and if they
> ever changed we won't even notice, but rather the test will just become
> a silent noop).
>
> I think it would be nice if we could m
On Mon, Sep 10, 2018 at 04:07:14PM +0200, SZEDER Gábor wrote:
> The test 'add -p does not expand argument lists' in
> 't3701-add-interactive.sh', added in 7288e12cce (add--interactive: do
> not expand pathspecs with ls-files, 2017-03-14), checks the GIT_TRACE
> of 'git add -p' to ensure that the n
> Tighten this 'grep' pattern to only match trace lines that show the
> executed commands.
Looks good, and I think that this is the only such occurrence in t3701
that needs this treatment.
Signed-off-by: Taylor Blau
The test 'add -p does not expand argument lists' in
't3701-add-interactive.sh', added in 7288e12cce (add--interactive: do
not expand pathspecs with ls-files, 2017-03-14), checks the GIT_TRACE
of 'git add -p' to ensure that the name of a tracked file wasn't
passed around as argument to any of the co
7 matches
Mail list logo
