Re: [PATCH] t5500: prettify non-commit tag tests

2018-07-03 Thread Kirill Smelkov
On Tue, Jul 03, 2018 at 12:55:19PM -0400, Jeff King wrote: > I had prepared this as a squash-in for what became c12c9df527, but since > that's now in master, it can go on top (or get dropped, but I think it > is worth it as a style fixup). I'm ok with the patch. I thought it was already squashed i

Re: [PATCH] t5500: prettify non-commit tag tests

2018-07-03 Thread Taylor Blau
On Tue, Jul 03, 2018 at 12:55:19PM -0400, Jeff King wrote: > We don't need to use backslash continuation, as the "&&" > already provides continuation (and happily soaks up empty > lines between commands). OK. That seems correct according to my recollection. > We can also expand the multi-line pri

[PATCH] t5500: prettify non-commit tag tests

2018-07-03 Thread Jeff King
We don't need to use backslash continuation, as the "&&" already provides continuation (and happily soaks up empty lines between commands). We can also expand the multi-line printf into a here-document, which lets us use line breaks more naturally (and avoids another continuation that required us