Re: [PATCH] t5614: don't use subshells

2016-06-21 Thread Stefan Beller
On Tue, Jun 21, 2016 at 12:38 PM, Jeff King wrote: > On Tue, Jun 21, 2016 at 12:18:29PM -0700, Junio C Hamano wrote: > >> Stefan Beller writes: >> >> > Unlike the prior patch we would not want this patch to fall through >> > to origin/maint fast, but allow cooking? >> >> I do not see anything t

Re: [PATCH] t5614: don't use subshells

2016-06-21 Thread Jeff King
On Tue, Jun 21, 2016 at 12:18:29PM -0700, Junio C Hamano wrote: > Stefan Beller writes: > > > Unlike the prior patch we would not want this patch to fall through > > to origin/maint fast, but allow cooking? > > I do not see anything that makes this treated differently from the > other fix. T

Re: [PATCH] t5614: don't use subshells

2016-06-21 Thread Junio C Hamano
Stefan Beller writes: > Unlike the prior patch we would not want this patch to fall through > to origin/maint fast, but allow cooking? I do not see anything that makes this treated differently from the other fix. The only difference in behaviour is that "lines" file is now created at the root

[PATCH] t5614: don't use subshells

2016-06-20 Thread Stefan Beller
Using a subshell for just one git command is both a waste in compute overhead (create a new process) as well as in line count. Suggested-by: Jeff King Signed-off-by: Stefan Beller --- Junio, This goes on top of the patch that I just sent "[PATCH] shallow clone to not imply shallow submodule