Re: [PATCH] t6026-merge-attr: wait for process to release trash directory

2016-09-09 Thread Johannes Schindelin
Hi Peff, On Thu, 8 Sep 2016, Jeff King wrote: > On Thu, Sep 08, 2016 at 10:05:58AM +0200, Johannes Schindelin wrote: > > > > > Is fifo safe on Windows, though? > > > > > > No clue. We seem to use mkfifo unconditionally in lib-daemon, but > > > perhaps people do not run that test on Windows. Oth

Re: [PATCH] t6026-merge-attr: wait for process to release trash directory

2016-09-08 Thread Jeff King
On Thu, Sep 08, 2016 at 10:05:58AM +0200, Johannes Schindelin wrote: > > > Is fifo safe on Windows, though? > > > > No clue. We seem to use mkfifo unconditionally in lib-daemon, but > > perhaps people do not run that test on Windows. Other invocations seem > > to be protected by the PIPE prerequi

Re: [PATCH] t6026-merge-attr: wait for process to release trash directory

2016-09-08 Thread Johannes Schindelin
Hi Peff & Junio, On Wed, 7 Sep 2016, Jeff King wrote: > On Wed, Sep 07, 2016 at 11:39:57AM -0700, Junio C Hamano wrote: > > > > Can we do some signaling with fifos to tell the hook when it is safe to > > > exit? Then we would just need to `wait` for its parent process. > > > > Is fifo safe on W

Re: [PATCH] t6026-merge-attr: wait for process to release trash directory

2016-09-07 Thread Junio C Hamano
Jeff King writes: > I agree that the sleep could be made longer, to make the test less racy. > However, the racy failure mode is that it might pass while testing > nothing (i.e., the sleep ends anyway before the hook returns), so I > don't think it's a high priority. I do not think it is necessa

Re: [PATCH] t6026-merge-attr: wait for process to release trash directory

2016-09-07 Thread Jeff King
On Wed, Sep 07, 2016 at 11:39:57AM -0700, Junio C Hamano wrote: > > Can we do some signaling with fifos to tell the hook when it is safe to > > exit? Then we would just need to `wait` for its parent process. > > Is fifo safe on Windows, though? No clue. We seem to use mkfifo unconditionally in l

Re: [PATCH] t6026-merge-attr: wait for process to release trash directory

2016-09-07 Thread Junio C Hamano
Jeff King writes: > On Mon, Sep 05, 2016 at 09:03:48PM +0200, Johannes Sixt wrote: > >> The process spawned in the hook uses the test's trash directory as CWD. >> As long as it is alive, the directory cannot be removed on Windows. >> Although the test succeeds, the 'test_done' that follows produc

Re: [PATCH] t6026-merge-attr: wait for process to release trash directory

2016-09-06 Thread Jeff King
On Mon, Sep 05, 2016 at 09:03:48PM +0200, Johannes Sixt wrote: > The process spawned in the hook uses the test's trash directory as CWD. > As long as it is alive, the directory cannot be removed on Windows. > Although the test succeeds, the 'test_done' that follows produces an > error message and

Re: [PATCH] t6026-merge-attr: wait for process to release trash directory

2016-09-06 Thread Johannes Schindelin
Hi Hannes, On Mon, 5 Sep 2016, Johannes Sixt wrote: > The process spawned in the hook uses the test's trash directory as CWD. > As long as it is alive, the directory cannot be removed on Windows. > Although the test succeeds, the 'test_done' that follows produces an > error message and leaves the

[PATCH] t6026-merge-attr: wait for process to release trash directory

2016-09-05 Thread Johannes Sixt
The process spawned in the hook uses the test's trash directory as CWD. As long as it is alive, the directory cannot be removed on Windows. Although the test succeeds, the 'test_done' that follows produces an error message and leaves the trash directory around. Insert a delay to give the hook time