On 2018.10.24 10:50, Johannes Schindelin wrote:
> Maybe a lot of explanation, but definitely a good one. The explanation and
> the patch look good to me.
>
> Thanks,
> Dscho
Agreed, as a newbie I definitely appreciate detailed explanations. Looks
good to me as well.
Reviewed-by: Josh Steadmon
Hi Peff,
On Wed, 24 Oct 2018, Jeff King wrote:
> The upload_pack_config() callback uses an if/else chain
> like:
>
> if (!strcmp(var, "a"))
> ...
> else if (!strcmp(var, "b"))
> ...
> etc
>
> This works as long as the conditions are mutually exclusive,
> but one of them is not.
The upload_pack_config() callback uses an if/else chain
like:
if (!strcmp(var, "a"))
...
else if (!strcmp(var, "b"))
...
etc
This works as long as the conditions are mutually exclusive,
but one of them is not. 20b20a22f8 (upload-pack: provide a
hook for running pack-objects,
3 matches
Mail list logo
