Re: [PATCH] verify-tag: allow to verify signed blob objects

2016-06-16 Thread Junio C Hamano
Michael J Gruber writes: > Currently, there is no easy way to verify push certificates. They have > the same structure as signed tags: "attached detached signatures", that > is: the concatenation of the signed material and its detached signature. > > Introduce a `--blob` option to verify-tag so t

Re: [PATCH] verify-tag: allow to verify signed blob objects

2016-06-15 Thread Jacob Keller
On Wed, Jun 15, 2016 at 12:24 PM, Junio C Hamano wrote: > Michael J Gruber writes: > >>> Or even >>> >>> if ((flags & GPG_VERIFY_BLOB) && (type != OBJ_BLOB)) >>> "you told me to check blob but didn't give me one"; >>> } else if (type != OBJ_TAG) >>> "yo

Re: [PATCH] verify-tag: allow to verify signed blob objects

2016-06-15 Thread Junio C Hamano
Michael J Gruber writes: >> Or even >> >> if ((flags & GPG_VERIFY_BLOB) && (type != OBJ_BLOB)) >> "you told me to check blob but didn't give me one"; >> } else if (type != OBJ_TAG) >> "you didn't give me a tag"; >> > > I just tried to stay as close to

Re: [PATCH] verify-tag: allow to verify signed blob objects

2016-06-15 Thread Michael J Gruber
Junio C Hamano venit, vidit, dixit 15.06.2016 20:39: > Michael J Gruber writes: > >> diff --git a/tag.c b/tag.c >> index d1dcd18..d5f090b 100644 >> --- a/tag.c >> +++ b/tag.c >> @@ -39,7 +39,7 @@ int gpg_verify_tag(const unsigned char *sha1, const char >> *name_to_report, >> int ret; >> >

Re: [PATCH] verify-tag: allow to verify signed blob objects

2016-06-15 Thread Junio C Hamano
Michael J Gruber writes: > diff --git a/tag.c b/tag.c > index d1dcd18..d5f090b 100644 > --- a/tag.c > +++ b/tag.c > @@ -39,7 +39,7 @@ int gpg_verify_tag(const unsigned char *sha1, const char > *name_to_report, > int ret; > > type = sha1_object_info(sha1, NULL); > - if (type !=

[PATCH] verify-tag: allow to verify signed blob objects

2016-06-15 Thread Michael J Gruber
Currently, there is no easy way to verify push certificates. They have the same structure as signed tags: "attached detached signatures", that is: the concatenation of the signed material and its detached signature. Introduce a `--blob` option to verify-tag so that it allows to verify tags and blo