Re: [PATCH 0/2] Demonstrate and partially work around a gitattributes problem

2017-05-18 Thread Jeff King
On Thu, May 18, 2017 at 09:23:17PM +0200, Johannes Schindelin wrote: > So you drive this forward? That would really help me a lot. Please make my > 1/2 part of your patches to that end. Yes, sorry, I haven't gotten a chance to polish the patches yet. -Peff

Re: [PATCH 0/2] Demonstrate and partially work around a gitattributes problem

2017-05-18 Thread Johannes Schindelin
Hi Peff, On Tue, 16 May 2017, Jeff King wrote: > On Wed, May 17, 2017 at 10:38:36AM +0900, Junio C Hamano wrote: > > > > - add_pending_object(revs, a_obj, this); > > > - add_pending_object(revs, b_obj, next); > > > +

Re: [PATCH 0/2] Demonstrate and partially work around a gitattributes problem

2017-05-16 Thread Jeff King
On Wed, May 17, 2017 at 10:38:36AM +0900, Junio C Hamano wrote: > > - add_pending_object(revs, a_obj, this); > > - add_pending_object(revs, b_obj, next); > > + add_pending_object_with_path(revs, a_obj, this, > > +

Re: [PATCH 0/2] Demonstrate and partially work around a gitattributes problem

2017-05-16 Thread Junio C Hamano
Jeff King writes: > diff --git a/builtin/diff.c b/builtin/diff.c > index d184aafab..8ed1e99e3 100644 > --- a/builtin/diff.c > +++ b/builtin/diff.c > @@ -409,7 +409,7 @@ int cmd_diff(int argc, const char **argv, const char > *prefix) > if (2 <= blobs) >

Re: [PATCH 0/2] Demonstrate and partially work around a gitattributes problem

2017-05-16 Thread Jeff King
On Tue, May 16, 2017 at 03:54:18AM -0400, Jeff King wrote: > Something like the patch below almost gets us there, but it suffers from > the fact that the revision machinery doesn't record the path for the > blobs it parses. So: > > 1. It's a little inefficient, because it has to re-resolve the

Re: [PATCH 0/2] Demonstrate and partially work around a gitattributes problem

2017-05-16 Thread Jeff King
On Mon, May 15, 2017 at 05:23:44PM +0200, Johannes Schindelin wrote: > Granted, it is a bit of a less common use case to call > > git diff : : > > There are valid scenarios for such calls, of course. > > And sometimes, one may want to compare even files that are stored in >

[PATCH 0/2] Demonstrate and partially work around a gitattributes problem

2017-05-15 Thread Johannes Schindelin
Granted, it is a bit of a less common use case to call git diff : : There are valid scenarios for such calls, of course. And sometimes, one may want to compare even files that are stored in subdirectories instead of the top-level directory. Example: git diff cafebabe:t/README