Re: [PATCH 0/2] friendlier handling of overflows in archive-tar

2016-06-21 Thread Junio C Hamano
Jeff King writes: > Junio, this is the jk/big-and-old-archive-tar topic. > > The interdiff is: > ... > diff --git a/archive-tar.c b/archive-tar.c > index c7b85fd..ed562d4 100644 > --- a/archive-tar.c > +++ b/archive-tar.c > @@ -179,7 +179,7 @@ static size_t get_path_prefix(const

Re: [PATCH 0/2] friendlier handling of overflows in archive-tar

2016-06-21 Thread Jeff King
On Thu, Jun 16, 2016 at 12:35:23AM -0400, Jeff King wrote: > The ustar format has some fixed-length numeric fields, and it's possible > to generate a git tree that can't be represented (namely file size and > mtime). Since f2f0267 (archive-tar: use xsnprintf for trivial > formatting, 2015-09-24),

Re: [PATCH 0/2] friendlier handling of overflows in archive-tar

2016-06-16 Thread Junio C Hamano
Both patches looked good to me. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 0/2] friendlier handling of overflows in archive-tar

2016-06-15 Thread Jeff King
The ustar format has some fixed-length numeric fields, and it's possible to generate a git tree that can't be represented (namely file size and mtime). Since f2f0267 (archive-tar: use xsnprintf for trivial formatting, 2015-09-24), we detect and die() in these cases. But we can actually do the