Re: [PATCH 0/2] git-p4: Small updates to test cases

2015-03-26 Thread Vitor Antunes
On Fri, 27 Mar 2015 at 01:26 Junio C Hamano wrote: >As to 1/2 the lack of esac is clearly a bug---any self respecting >POSIX shell should have executed it without complaining. But >changing from ':' to true should not be necessary---after all, the >colon is a more traditional way to spell true to

Re: [PATCH 0/2] git-p4: Small updates to test cases

2015-03-26 Thread Junio C Hamano
Junio C Hamano writes: > As to 1/2 the lack of esac is clearly a bug---any self respecting > POSIX shell should have executed it without complaining. But s/should/shouldn't/; sorry for a noise. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord.

Re: [PATCH 0/2] git-p4: Small updates to test cases

2015-03-26 Thread Junio C Hamano
Vitor Antunes writes: > This patch set includes two small fixes to the rename test case. The fix to > support dash should be trivial, but in the fix to the copy detection test case > it isn't obvious to me what changed in diff-tree to result in a different file > being detected as the origin of a

[PATCH 0/2] git-p4: Small updates to test cases

2015-03-26 Thread Vitor Antunes
This patch set includes two small fixes to the rename test case. The fix to support dash should be trivial, but in the fix to the copy detection test case it isn't obvious to me what changed in diff-tree to result in a different file being detected as the origin of a copy. Vitor Antunes (2): git