Re: [PATCH 0/2] squelch some "gcc -O3 -Wmaybe-uninitialized" warnings

2016-09-01 Thread Jeff King
On Wed, Aug 31, 2016 at 12:55:01PM -0700, Junio C Hamano wrote: > Interesting. Here is for "gcc -Os" on top to appease gcc 4.8.4 that > I probably am NOT going to apply. These are all false positives. > > The ones on config.c is the most curious as these two "ret" needs a > false

Re: [PATCH 0/2] squelch some "gcc -O3 -Wmaybe-uninitialized" warnings

2016-08-31 Thread Junio C Hamano
Jeff King writes: > I happened to be compiling git with -O3 today, and noticed we generate > some warnings about uninitialized variables (I actually compile with > -Wall, but the only false positives I saw were these). > > Here are patches to squelch them. > > [1/2]:

[PATCH 0/2] squelch some "gcc -O3 -Wmaybe-uninitialized" warnings

2016-08-30 Thread Jeff King
I happened to be compiling git with -O3 today, and noticed we generate some warnings about uninitialized variables (I actually compile with -Wall, but the only false positives I saw were these). Here are patches to squelch them. [1/2]: error_errno: use constant return similar to error()