Re: [PATCH 0/3] fix parse-opt string_list leaks

2016-06-13 Thread Duy Nguyen
On Mon, Jun 13, 2016 at 12:32 PM, Jeff King wrote: > On Mon, Jun 13, 2016 at 07:08:55AM +0700, Duy Nguyen wrote: > >> > So if we are doing the conservative thing, then I think the resulting >> > code should either look like: >> > >> > if (!v->strdup_strings) >> >

[PATCH 0/3] fix parse-opt string_list leaks

2016-06-12 Thread Jeff King
On Mon, Jun 13, 2016 at 07:08:55AM +0700, Duy Nguyen wrote: > > So if we are doing the conservative thing, then I think the resulting > > code should either look like: > > > > if (!v->strdup_strings) > > die("BUG: OPT_STRING_LIST should always use strdup_strings"); > >