Re: [PATCH 0/3] git-describe deals gracefully with broken submodules

2017-03-21 Thread Stefan Beller
On Mon, Mar 20, 2017 at 11:28 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> Our own version generation in GIT-VERSION-GEN is somewhat sane by testing >> if we have a .git dir, and use that as a signal whether the obtained >> copy of git was obtained using git (clone/fetch) or if it is ju

Re: [PATCH 0/3] git-describe deals gracefully with broken submodules

2017-03-20 Thread Junio C Hamano
Junio C Hamano writes: > I do not have a strong preference for or against the "treat a broken > repository as if nothing is wrong with the revision, but just mark > it as dirty" idea. I would be more receptive if it substituted the > "-dirty" marker with something else, e.g. "-broken", though. >

Re: [PATCH 0/3] git-describe deals gracefully with broken submodules

2017-03-20 Thread Junio C Hamano
Stefan Beller writes: > Our own version generation in GIT-VERSION-GEN is somewhat sane by testing > if we have a .git dir, and use that as a signal whether the obtained > copy of git was obtained using git (clone/fetch) or if it is just a > downloaded tar ball. > > Other scripts to generate a ver

[PATCH 0/3] git-describe deals gracefully with broken submodules

2017-03-20 Thread Stefan Beller
Our own version generation in GIT-VERSION-GEN is somewhat sane by testing if we have a .git dir, and use that as a signal whether the obtained copy of git was obtained using git (clone/fetch) or if it is just a downloaded tar ball. Other scripts to generate a version are not as cautious and just r