Re: [PATCH 0/4] config.h

2017-06-12 Thread Jonathan Nieder
Brandon Williams wrote: > Brandon Williams (4): > config: create config.h > config: remove git_config_iter > config: don't include config.h by default > config: don't implicitly use gitdir Patches 1-3 are Reviewed-by: Jonathan Nieder I'm very happy to see cache.h getting shorter and le

Re: [PATCH 0/4] config.h

2017-06-12 Thread Brandon Williams
On 06/12, Jeff King wrote: > On Mon, Jun 12, 2017 at 02:53:52PM -0700, Brandon Williams wrote: > > > > These all seem reasonable to me. Patch 3 made me shrug a little, because > > > it seems like the majority of C files end up including it anyway. I > > > suspect you could break config.h down into

Re: [PATCH 0/4] config.h

2017-06-12 Thread Jeff King
On Mon, Jun 12, 2017 at 02:53:52PM -0700, Brandon Williams wrote: > > These all seem reasonable to me. Patch 3 made me shrug a little, because > > it seems like the majority of C files end up including it anyway. I > > suspect you could break config.h down into two files: the few things > > that e

Re: [PATCH 0/4] config.h

2017-06-12 Thread Brandon Williams
On 06/12, Jeff King wrote: > On Mon, Jun 12, 2017 at 02:34:02PM -0700, Brandon Williams wrote: > > > After some discussion I realized that my 'repository object' series was > > getting > > to be rather long and increase in scope. So I've decided to break off these > > couple patches into their o

Re: [PATCH 0/4] config.h

2017-06-12 Thread Jeff King
On Mon, Jun 12, 2017 at 02:34:02PM -0700, Brandon Williams wrote: > After some discussion I realized that my 'repository object' series was > getting > to be rather long and increase in scope. So I've decided to break off these > couple patches into their own series so they can be reviewed more

[PATCH 0/4] config.h

2017-06-12 Thread Brandon Williams
After some discussion I realized that my 'repository object' series was getting to be rather long and increase in scope. So I've decided to break off these couple patches into their own series so they can be reviewed more easily. This should also let them be merged in faster as I suspect it'll ta